Skip to content

Increase Check Domains request timeout#306

Merged
glenn-jocher merged 2 commits into
mainfrom
check-domains-longer-timeout
May 8, 2026
Merged

Increase Check Domains request timeout#306
glenn-jocher merged 2 commits into
mainfrom
check-domains-longer-timeout

Conversation

@glenn-jocher
Copy link
Copy Markdown
Member

@glenn-jocher glenn-jocher commented May 8, 2026 •
edited by UltralyticsAssistant
Loading

Summary

  • Increase the Check Domains per-request timeout from 10 seconds to 20 seconds.
  • Add one more retry attempt, increasing each domain check from 5 attempts to 6.

Validation

  • actionlint .github/workflows/check_domains.yml
  • git diff --check

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

🔧 This PR makes the domain-checking GitHub Action more reliable by increasing retry attempts and allowing more time for redirect requests to complete.

📊 Key Changes

  • Increased the maximum number of retry attempts in .github/workflows/check_domains.yml from 5 to 6 🔁
  • Extended the HTTP request timeout for domain redirect checks from 10 seconds to 20 seconds ⏱️
  • Kept the existing redirect validation logic the same, still verifying that domains resolve successfully to approved destinations like ultralytics.com and yolo11.com ✅

🎯 Purpose & Impact

  • Reduces false CI failures caused by slow network responses or temporary redirect delays 🌐
  • Makes automated domain validation more stable and resilient in GitHub Actions 🛠️
  • Helps maintain smoother documentation and site infrastructure checks without changing user-facing behavior 📚
  • Improves confidence that valid redirects will pass even under less-than-ideal network conditions 🚀

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment May 8, 2026 7:03am

Request Review

@UltralyticsAssistant UltralyticsAssistant added devops GitHub Devops or MLops enhancement New feature or request priority: low Low urgency; can wait behind higher-priority work. labels May 8, 2026
@UltralyticsAssistant
Copy link
Copy Markdown
Member

UltralyticsAssistant commented May 8, 2026

👋 Hello @glenn-jocher, thank you for submitting a ultralytics/docs 🚀 PR! This is an automated message to help streamline review, and an engineer will assist you shortly 😊 Please review the checklist below to support a smooth merge:

  • ✅ Define a Purpose: Clearly explain the purpose of your fix or feature in your PR description, and link to any relevant issues. Ensure your commit messages are clear, concise, and adhere to the project's conventions.
  • ✅ Synchronize with Source: Confirm your PR is synchronized with the ultralytics/docs main branch. If it's behind, update it by clicking the 'Update branch' button or by running git pull and git merge main locally.
  • ✅ Ensure CI Checks Pass: Verify all Ultralytics Continuous Integration (CI) checks are passing. If any checks fail, please address the issues.
  • ✅ Update Documentation: Update the relevant documentation for any new or modified features.
  • ✅ Add Tests: If applicable, include or update tests to cover your changes, and confirm that all tests are passing.
  • ✅ Sign the CLA: Please ensure you have signed our Contributor License Agreement if this is your first Ultralytics PR by writing "I have read the CLA Document and I sign the CLA" in a new message.
  • ✅ Minimize Changes: Limit your changes to the minimum necessary for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee

For more guidance, please refer to our Contributing Guide. Don't hesitate to leave a comment if you have any questions. Thank you for contributing to Ultralytics! 🚀

UltralyticsAssistant
UltralyticsAssistant approved these changes May 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@UltralyticsAssistant UltralyticsAssistant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 PR Review

Made with ❤️ by Ultralytics Actions

The diff looks clean. Increasing the retry count and request timeout is consistent with the stated goal of reducing transient CI failures, and I don't see any clear bugs or maintainability issues introduced by these two changes.

@glenn-jocher glenn-jocher merged commit ef41cf8 into main May 8, 2026
7 checks passed
@glenn-jocher glenn-jocher deleted the check-domains-longer-timeout branch May 8, 2026 07:12
@UltralyticsAssistant
Copy link
Copy Markdown
Member

UltralyticsAssistant commented May 8, 2026

Merged! 🎉 Thanks, @glenn-jocher, for strengthening our domain-checking workflow with smarter retry and timeout tuning.

As Benjamin Franklin said, “An ounce of prevention is worth a pound of cure.” This update is a great example of that mindset in action—reducing false CI failures, improving redirect validation reliability, and helping keep our docs infrastructure smooth and dependable without changing user-facing behavior.

Really appreciate the thoughtful improvement to the stability of our automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@UltralyticsAssistant UltralyticsAssistant UltralyticsAssistant approved these changes

Assignees

No one assigned

Labels

devops GitHub Devops or MLops enhancement New feature or request priority: low Low urgency; can wait behind higher-priority work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@glenn-jocher @UltralyticsAssistant